Page 1 of 1
[Fixed] You can start the song even when a client lacks it.
Posted: Fri Oct 12, 2012 3:21 pm
by houkouonchi
Guessing its probably due to latency of a client reporting back it doesn't have the song? I ran into this with Angelo in the server and started (causing my client to hang) even though someone in the room lacked it.
I was trying to be an ass cause the guy kept starting songs without warning and I was going to do the same. Of course I was ~3ms from the server and I am guessing he was a lot farther so i selected/started it quicker than his client could report back he was missing (guessing).
Re: You can start the song even when a client lacks it.
Posted: Fri Oct 12, 2012 3:33 pm
by Angelo
I fixed this in my latest git commit just 15 minutes ago.
(Move to graveyard please?
)
Re: You can start the song even when a client lacks it.
Posted: Fri Oct 12, 2012 4:23 pm
by Izzy
I'm gong to create a developer usergroup and give you local mod powers for the bugreport section. I'll move this though.
Edit: You should have moderator permissions for bug report forum now.
Re: You can start the song even when a client lacks it.
Posted: Fri Oct 12, 2012 5:35 pm
by Cube
Compiled and now running. Thanks Angelo!
Re: You can start the song even when a client lacks it.
Posted: Fri Oct 12, 2012 6:54 pm
by houkouonchi
Re: You can start the song even when a client lacks it.
Posted: Fri Oct 12, 2012 7:05 pm
by Izzy
Unlocked and moved back to bug reports.
Re: You can start the song even when a client lacks it.
Posted: Fri Oct 12, 2012 7:20 pm
by houkouonchi
Also when a new client joins after a song is selected it aparrantly will let you start a song even if they don't have it causing the same client hang. Just ran into this.
Re: You can start the song even when a client lacks it.
Posted: Sun Oct 14, 2012 5:42 am
by Angelo
Eh, sorry. I didn't get much time to test it yet. I still don't have my own internet here, so I can't locally debug with people connecting to my PC.
I'll check it out.
Re: You can start the song even when a client lacks it.
Posted: Sun Oct 14, 2012 6:27 am
by -Slayeur-
Re: You can start the song even when a client lacks it.
Posted: Tue Oct 16, 2012 10:50 am
by Angelo
Fixed, see Git repo.
(I can't seem to be able to move this thread to the graveyard, though?)
Re: You can start the song even when a client lacks it.
Posted: Tue Oct 16, 2012 10:56 am
by Izzy
I'll look into it. The forum permissions for non global mods were set up very strangely.
Thank you for the fix.
Re: You can start the song even when a client lacks it.
Posted: Tue Oct 16, 2012 7:07 pm
by houkouonchi
This appears to not be 100% fixed. It did work sometimes if I wasn't really spammy with it but when I spammed the hell out of it on multiple songs it eventually played and my client hung.
Re: You can start the song even when a client lacks it.
Posted: Tue Oct 16, 2012 7:15 pm
by foxfire667
Re: You can start the song even when a client lacks it.
Posted: Tue Oct 16, 2012 10:59 pm
by Angelo
That's weird, it shouldn't be doing that. I've been testing on localhost, so ofcourse there will be no lag from the server to client.
Select the song once, wait for it to say that the client doesn't have it and start spamming then. If that's the case, I know another fix.
Re: You can start the song even when a client lacks it.
Posted: Wed Oct 17, 2012 12:41 am
by houkouonchi