[Fixed] You can start the song even when a client lacks it.

Postby **houkouonchi** » Fri Oct 12, 2012 3:21 pm

Guessing its probably due to latency of a client reporting back it doesn't have the song? I ran into this with Angelo in the server and started (causing my client to hang) even though someone in the room lacked it.

I was trying to be an ass cause the guy kept starting songs without warning and I was going to do the same. Of course I was ~3ms from the server and I am guessing he was a lot farther so i selected/started it quicker than his client could report back he was missing (guessing).

Postby **Angelo** » Fri Oct 12, 2012 3:33 pm

I fixed this in my latest git commit just 15 minutes ago.

(Move to graveyard please?

)

Postby **Izzy** » Fri Oct 12, 2012 4:23 pm

I'm gong to create a developer usergroup and give you local mod powers for the bugreport section. I'll move this though.

Edit: You should have moderator permissions for bug report forum now.

Postby **Cube** » Fri Oct 12, 2012 5:35 pm

Compiled and now running. Thanks Angelo!

Postby **houkouonchi** » Fri Oct 12, 2012 6:54 pm

Postby **Izzy** » Fri Oct 12, 2012 7:05 pm

Unlocked and moved back to bug reports.

Postby **houkouonchi** » Fri Oct 12, 2012 7:20 pm

Also when a new client joins after a song is selected it aparrantly will let you start a song even if they don't have it causing the same client hang. Just ran into this.

Postby **Angelo** » Sun Oct 14, 2012 5:42 am

Eh, sorry. I didn't get much time to test it yet. I still don't have my own internet here, so I can't locally debug with people connecting to my PC.

I'll check it out.

Postby **-Slayeur-** » Sun Oct 14, 2012 6:27 am

Postby **Angelo** » Tue Oct 16, 2012 10:50 am

Fixed, see Git repo.

(I can't seem to be able to move this thread to the graveyard, though?)

Postby **Izzy** » Tue Oct 16, 2012 10:56 am

I'll look into it. The forum permissions for non global mods were set up very strangely.

Thank you for the fix.

Postby **houkouonchi** » Tue Oct 16, 2012 7:07 pm

This appears to not be 100% fixed. It did work sometimes if I wasn't really spammy with it but when I spammed the hell out of it on multiple songs it eventually played and my client hung.

Postby **foxfire667** » Tue Oct 16, 2012 7:15 pm

Postby **Angelo** » Tue Oct 16, 2012 10:59 pm

That's weird, it shouldn't be doing that. I've been testing on localhost, so ofcourse there will be no lag from the server to client.

Select the song once, wait for it to say that the client doesn't have it and start spamming then. If that's the case, I know another fix.

Postby **houkouonchi** » Wed Oct 17, 2012 12:41 am

Stepmania Online

[Fixed] You can start the song even when a client lacks it.

[Fixed] You can start the song even when a client lacks it.

Re: You can start the song even when a client lacks it.

Re: You can start the song even when a client lacks it.

Re: You can start the song even when a client lacks it.

Re: You can start the song even when a client lacks it.

Re: You can start the song even when a client lacks it.

Re: You can start the song even when a client lacks it.

Re: You can start the song even when a client lacks it.

Re: You can start the song even when a client lacks it.

Re: You can start the song even when a client lacks it.

Re: You can start the song even when a client lacks it.

Re: You can start the song even when a client lacks it.

Re: You can start the song even when a client lacks it.

Re: You can start the song even when a client lacks it.

Re: You can start the song even when a client lacks it.

Who is online