[Fixed] Scores are swapped in at the SMO results screen.

[foxfire667]

You may have heard this from others, but I'll put it here since it isn't listed in the bug report thread or the graveyard.

When there are multiple people in an SMO room, sometimes the scores are swapped around at the results screen. This means that I cannot actually tell which scores were obtained by which player, which is a little bit obnoxious when I want to compare with people. Obviously this isn't a major issue, but since it is frequently occurring, I figure it should be brought to your attention. Hopefully this can be resolved in the near future!

[houkouonchi]

We are indeed aware of the issue. For some reason it is listing the users in room order (not score order) even though there is code there to sort it by score.

Its something that definitely will be getting fixed in the future.

Its only a major problem right now if you have more than 3 people playing as you can still usually tell who is who by the modifiers that they are using.

[blind]

Yeah, hou said it should be an easy fix. It actually just shows up in order of the room.

Edit: ninja'd. -_-

[Angelo]

Hou, please remind me, where exactly did I put this code?

[Cube]

Looks like it was in User.cs

This file has changed quite a bit since I las looked at it. I remember it being in the NSCGON function before...

Now I don't really know and am super busy right now to really search for it.

[Angelo]

Fixed.

See change: https://github.com/AngeloG/OpenSMO/comm ... f4e11a0b91

[Cube]

Awesome thanks. So it looks like you took this out in one of the commits, is this the same code just added back in?

I will get it compiled and tested tonight.

[Angelo]

For some reason, it magically disappeared out of the main Git repository. I'm not sure why, but I re-added the code and changed the order of the players in the list to match the room order. It should work fine now.

[houkouonchi]

This appears like it might be fixed however at the end the users are not listed in score order. Honestly I can live with for now as long as the names/scores always match up.

[foxfire667]

This might not be completely killed yet.

It works perfectly fine with two people, but when I was playing in a room with 3 or more participants, the scores were getting mixed up again.

[houkouonchi]

[foxfire667]

[houkouonchi]

This is finally fixed (order by top score) and player/names match.

Previously it was in score order but ID's were in room order. the cause was pretty strait forward when i finally dug into the code.

Before the array was being re-ordered. That was working fine but when it sent the name index it was just using a for loop and sending i (not touching the re-ordered index) which meant the value for which name it was would always be in order 0, 1, 2 etc.. in the room/connection to server order.

I just applied the same logic Angelo used in another part (during play the combo/grade/score update thingy) and have another for loop (as j) inside the original using the original array and when the array values are equal instead of using i it uses the j value instead of i.

Long story short scores now are in score descending order and names match their score/counts.

[blind]

Awesome man, thanks! Was quite an annoyance that was tolerable.