[Fixed] Timing flag doesn't trigger

Information and error posts in regards to testing.
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable
User avatar
Izzy
Moderator
Posts: 531
Joined: Thu Sep 27, 2012 3:03 pm
Location: Leawood, Kansas
Contact:

[Fixed] Timing flag doesn't trigger

Postby Izzy » Thu Oct 18, 2012 3:22 pm

When a player uses a judgement lower than 4 the timing modifier doesn't get added to the matchid's modifiers. We would like to be able to exclude "timing" scores from the highscores this way, but at the moment scores below judge 4 don't recieve a timing flag.

houkouonchi
Site Admin
Posts: 156
Joined: Sun Sep 16, 2012 1:12 pm
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable

Re: Timing flag doesn't trigger

Postby houkouonchi » Thu Oct 18, 2012 3:27 pm

This is probably the #1 feature that needs to be added. The old SMOnline could read new values from the INI but otherwised used the following defaults:

jw.SetMarv(PREFSMAN->GetValueF("JudgeWindows", "Marvelous", 0.022500f, 1));
jw.SetPerfect(PREFSMAN->GetValueF("JudgeWindows", "Perfect", 0.045000f, 1));
jw.SetGreat(PREFSMAN->GetValueF("JudgeWindows", "Great", 0.090000f, 1));
jw.SetGood(PREFSMAN->GetValueF("JudgeWindows", "Good", 0.135000f, 1));
jw.SetBoo(PREFSMAN->GetValueF("JudgeWindows", "Boo", 0.180000f, 1));

so 22.5ms, 45ms, 90ms, 135ms, 180ms. for flawless/perfect/great/good/barely.

User avatar
Izzy
Moderator
Posts: 531
Joined: Thu Sep 27, 2012 3:03 pm
Location: Leawood, Kansas
Contact:

Re: Timing flag doesn't trigger

Postby Izzy » Fri Oct 19, 2012 9:20 am

Agreed, this should be priority number 1.

I don't know if there is already a column in the database for "timing" or if just gets added to a string in the modifiers column but I would like to see a way to not include these scores to the highscore lists and also not give them exp.

Then eventually I'd like to see a button next to the scores for moderators to flag as timing if the community decides it was not legit.

User avatar
Angelo
Posts: 72
Joined: Sat Oct 06, 2012 4:31 am
Location: The Netherlands
Contact:

Re: Timing flag doesn't trigger

Postby Angelo » Fri Oct 19, 2012 9:47 am

Hm. I'm not sure if judge timings are sent in SMOP3...
- Angelo
developer

houkouonchi
Site Admin
Posts: 156
Joined: Sun Sep 16, 2012 1:12 pm
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable

Re: Timing flag doesn't trigger

Postby houkouonchi » Fri Oct 19, 2012 9:49 am


User avatar
Angelo
Posts: 72
Joined: Sat Oct 06, 2012 4:31 am
Location: The Netherlands
Contact:

Re: Timing flag doesn't trigger

Postby Angelo » Fri Oct 19, 2012 9:51 am

What makes you so positive that it's in SMOP3?
- Angelo
developer

houkouonchi
Site Admin
Posts: 156
Joined: Sun Sep 16, 2012 1:12 pm
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable

Re: Timing flag doesn't trigger

Postby houkouonchi » Fri Oct 19, 2012 9:57 am


User avatar
foxfire667
Moderator
Posts: 557
Joined: Sat Sep 29, 2012 5:09 pm
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable

Re: Timing flag doesn't trigger

Postby foxfire667 » Fri Oct 19, 2012 9:59 am


User avatar
Angelo
Posts: 72
Joined: Sat Oct 06, 2012 4:31 am
Location: The Netherlands
Contact:

Re: Timing flag doesn't trigger

Postby Angelo » Fri Oct 19, 2012 10:01 am

SM4 was SMOP2.

I'll look into it...
- Angelo
developer

User avatar
Izzy
Moderator
Posts: 531
Joined: Thu Sep 27, 2012 3:03 pm
Location: Leawood, Kansas
Contact:

Re: Timing flag doesn't trigger

Postby Izzy » Fri Oct 19, 2012 10:06 am


User avatar
Cube
Site Admin
Posts: 354
Joined: Mon Sep 24, 2012 10:18 am
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable

Re: Timing flag doesn't trigger

Postby Cube » Fri Oct 19, 2012 11:58 am



[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable

Return to “Bug Reports ONLY”

Who is online

Users browsing this forum: No registered users and 3 guests