Song difficulties higher than 15 don't show properly

Information and error posts in regards to testing.
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable
User avatar
foxfire667
Moderator
Posts: 557
Joined: Sat Sep 29, 2012 5:09 pm
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable

Song difficulties higher than 15 don't show properly

Postby foxfire667 » Sat Oct 20, 2012 3:13 pm

This bug is fairly straightforward. When a song has a higher difficulty rating than 15, the SMO website doesn't read it properly. What happens instead is it loops back around to 0 and counts up again.

So if you play a chart that has a difficulty of 16 for example, it will record in the stats as a difficulty of 0, and if you play a 20 it will record as a 4. It will loop around many times if you play a file with a much higher difficulty number, like say 100, but it will always stay within 0-15.

Needless to say, this bug makes looking at stats for harder files a bit confusing because the difficulties are all wrong. Hopefully this is something that can be fixed rather quickly to avoid any future user confusion with song stats.

User avatar
Cube
Site Admin
Posts: 354
Joined: Mon Sep 24, 2012 10:18 am
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable

Re: Song difficulties higher than 15 don't show properly

Postby Cube » Mon Oct 22, 2012 2:54 pm

Can you post a link to a match id that this occurred on?

User avatar
foxfire667
Moderator
Posts: 557
Joined: Sat Sep 29, 2012 5:09 pm
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable

Re: Song difficulties higher than 15 don't show properly

Postby foxfire667 » Mon Oct 22, 2012 3:00 pm

Any songs 16+ have this looping issue, but here is one of them as an example.

User avatar
Cube
Site Admin
Posts: 354
Joined: Mon Sep 24, 2012 10:18 am
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable

Re: Song difficulties higher than 15 don't show properly

Postby Cube » Mon Oct 22, 2012 3:26 pm

I figured it out, it was in the OpenSMO code. I will submit a pull request in a moment.

User avatar
foxfire667
Moderator
Posts: 557
Joined: Sat Sep 29, 2012 5:09 pm
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable

Re: Song difficulties higher than 15 don't show properly

Postby foxfire667 » Mon Oct 22, 2012 3:35 pm


User avatar
Cube
Site Admin
Posts: 354
Joined: Mon Sep 24, 2012 10:18 am
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable

Re: Song difficulties higher than 15 don't show properly

Postby Cube » Mon Oct 22, 2012 5:32 pm

Well I thought I could fix this... but the problem is with the Stepmania online protocol... The only thing the client sends to the server is the most significant 4 bits :(

Don't think there will be an easy fix for this one...

User avatar
Angelo
Posts: 72
Joined: Sat Oct 06, 2012 4:31 am
Location: The Netherlands
Contact:

Re: Song difficulties higher than 15 don't show properly

Postby Angelo » Tue Oct 23, 2012 4:44 am

- Angelo
developer

User avatar
Cube
Site Admin
Posts: 354
Joined: Mon Sep 24, 2012 10:18 am
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable

Re: Song difficulties higher than 15 don't show properly

Postby Cube » Tue Oct 23, 2012 8:25 am

haha, well I thought it was possible for a second...

User avatar
owenviau1
Posts: 136
Joined: Sat Nov 03, 2012 1:42 pm
Location: East of Canada
Contact:

Re: Song difficulties higher than 15 don't show properly

Postby owenviau1 » Mon Nov 05, 2012 3:15 am

I think your sm game put 15 as a MAX level people can change the difficulty in the .sm file in the songpack they can put it more then 15
Image

User avatar
Cube
Site Admin
Posts: 354
Joined: Mon Sep 24, 2012 10:18 am
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable

Re: Song difficulties higher than 15 don't show properly

Postby Cube » Mon Nov 05, 2012 2:10 pm



[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable

Return to “Bug Reports ONLY”

Who is online

Users browsing this forum: No registered users and 9 guests